Fix uniqueUnitItems typo and add assignedItems switch #922
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
commy2
approved these changes
May 13, 2018
jonpas
reviewed
May 17, 2018
| @@ -10,6 +10,7 @@ Parameters: | |||
| _backpack - Include items in backpack (Default: true) | |||
| _vest - Include items in vest (Default: true) | |||
| _uniform - Include items in uniform (Default: true) | |||
| _assignedItems - Include assigned items (Default: true) | |||
There was a problem hiding this comment.
What happened to alignment here?
There was a problem hiding this comment.
Dedmen just copy pasted a entry from above and changed the names. Dunno why I didn't see that
(╯°□°）╯︵ ┻━┻
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Not a critical bug. Just causes the function to return more items that advertised. Which given it's intended use case doesn't matter much.
Do you prefer to keep the useless semicolons that I removed?